Skip to content

Commit

Permalink
make itr_enabled config parameter true by default
Browse files Browse the repository at this point in the history
  • Loading branch information
anmarchenko committed Aug 15, 2024
1 parent db2dcde commit cbcac02
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/datadog/ci/configuration/settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def self.add_settings!(base)
option :itr_enabled do |o|
o.type :bool
o.env CI::Ext::Settings::ENV_ITR_ENABLED
o.default false
o.default true
end

option :git_metadata_upload_enabled do |o|
Expand Down
10 changes: 5 additions & 5 deletions spec/datadog/ci/configuration/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def patcher
describe "#itr_enabled" do
subject(:itr_enabled) { settings.ci.itr_enabled }

it { is_expected.to be false }
it { is_expected.to be true }

context "when #{Datadog::CI::Ext::Settings::ENV_ITR_ENABLED}" do
around do |example|
Expand All @@ -234,7 +234,7 @@ def patcher
context "is not defined" do
let(:enable) { nil }

it { is_expected.to be false }
it { is_expected.to be true }
end

context "is set to true" do
Expand All @@ -253,10 +253,10 @@ def patcher

describe "#itr_enabled=" do
it "updates the #enabled setting" do
expect { settings.ci.itr_enabled = true }
expect { settings.ci.itr_enabled = false }
.to change { settings.ci.itr_enabled }
.from(false)
.to(true)
.from(true)
.to(false)
end
end

Expand Down

0 comments on commit cbcac02

Please sign in to comment.