fix loaded? definitions for integrations; do not patch already patche…

…d integrations

lib/datadog/ci/contrib/cucumber/integration.rb

@@ -17,7 +17,7 @@ def version
           end
 
           def loaded?
-            !defined?(::Cucumber).nil? && !defined?(::Cucumber::Runtime).nil?
+            !defined?(::Cucumber).nil? && !defined?(::Cucumber::Runtime).nil? && !defined?(::Cucumber::Configuration).nil?
           end
 
           def compatible?

lib/datadog/ci/contrib/instrumentation.rb

@@ -46,6 +46,7 @@ def self.auto_instrument
 
           script_compiled_tracepoint = TracePoint.new(:script_compiled) do
             auto_instrumented_integrations.each do |integration|
+              next if integration.patched?
               next unless integration.loaded?
 
               Datadog.logger.debug("#{integration.class} is loaded")

lib/datadog/ci/contrib/integration.rb

@@ -93,9 +93,7 @@ def patcher
 
         # @!visibility private
         def patch
-          # @type var patcher_klass: untyped
-          patcher_klass = patcher
-          if !patchable? || patcher_klass.nil?
+          if !patchable? || patcher.nil?
             return {
               ok: false,
               available: available?,
@@ -105,10 +103,14 @@ def patch
             }
           end
 
-          patcher_klass.patch
+          patcher.patch
           {ok: true}
         end
 
+        def patched?
+          patcher&.patched?
+        end
+
         # Can the patch for this integration be applied automatically?
         # @return [Boolean] can the tracer activate this instrumentation without explicit user input?
         def late_instrument?

lib/datadog/ci/contrib/minitest/integration.rb

@@ -17,7 +17,8 @@ def version
           end
 
           def loaded?
-            !defined?(::Minitest).nil?
+            !defined?(::Minitest).nil? && !defined?(::Minitest::Runnable).nil? && !defined?(::Minitest::Test).nil? &&
+              !defined?(::Minitest::CompositeReporter).nil?
           end
 
           def compatible?

lib/datadog/ci/contrib/rspec/integration.rb

@@ -22,7 +22,9 @@ def version
 
           def loaded?
             !defined?(::RSpec).nil? && !defined?(::RSpec::Core).nil? &&
-              !defined?(::RSpec::Core::Example).nil?
+              !defined?(::RSpec::Core::Example).nil? &&
+              !defined?(::RSpec::Core::Runner).nil? &&
+              !defined?(::RSpec::Core::ExampleGroup).nil?
           end
 
           def compatible?

sig/datadog/ci/contrib/integration.rbs

@@ -20,7 +20,9 @@ module Datadog
 
         def enabled: () -> bool
 
-        def patcher: () -> Datadog::Tracing::Contrib::Patcher?
+        def patcher: () -> untyped
+
+        def patched?: () -> bool?
 
         def patch: () -> Hash[Symbol, bool]