Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-8333] better handling of test.type and span.kind tags #106

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jan 17, 2024

What does this PR do?

  • We no longer send test.type tag for session, modules, and suites as per citestcycle spec.
  • Ext::Test::SPAN_KIND_TEST constant is introduced to make clear that span.kind is not the same as type.
  • SPECIAL_TAGS is renamed to TRANSIENT_TAGS to communicate that these tags are not making it to backend
  • test.type tag has value "test" by default so we don't have to set it in each of the contrib integrations

Motivation

  • fix spec issue: we currently send test.type tag for session, modules, suites but citestcycle spec says that test.type is only for test events
  • span.kind purpose was confusing
  • some tag constant names were suboptimal

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dd092a) 99.10% compared to head (af2d55f) 99.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   99.10%   99.10%   -0.01%     
==========================================
  Files         149      149              
  Lines        6383     6374       -9     
  Branches      277      277              
==========================================
- Hits         6326     6317       -9     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title [CIVIS-8333] manual API improvements [CIVIS-8333] better handling of test.type and span.kind tags Jan 17, 2024
@anmarchenko anmarchenko marked this pull request as ready for review January 17, 2024 12:10
@anmarchenko anmarchenko requested review from a team as code owners January 17, 2024 12:10
@anmarchenko anmarchenko merged commit 7dd9027 into main Jan 17, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/manual_api_cleaning_up branch January 17, 2024 12:56
@github-actions github-actions bot added this to the 0.7.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants