[CIVIS-8333] get rid of span_type in tracer-related models #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename type to event_type in citestcycle serializers.
tonyredondo
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dd-trace-rb recently dropped span_type method for SpanOperation. In order to avoid confusion, I do the same in Datadog::CI context.
For serializers span_type method stays to distinguish it from event type (that can have slightly different meaning). To reduce confusion for future self and other contributors,
Serializers::Base#typeis renamed toSerializers::Base#event_typeMotivation
Reducing confusion and surprise level of our API