Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-8594] Enable test suite level visibility by default (with killswitch) #109

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jan 18, 2024

What does this PR do?
Deprecates and stops using ci.experimental_test_suite_level_visibility_enabled configuration option making test suite level visibility enabled by default.

Adds killswitch ci.force_test_level_visibility that allows users of this library to (temporarily) revert to test level visibility if any unanticipated issues occur.

Motivation
When Ruby library is generally available we'll use test suite level visibility as default.

@anmarchenko anmarchenko force-pushed the anmarchenko/enable_tslv_by_default branch from 610e53c to 4703f78 Compare January 18, 2024 15:28
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a21b953) 99.10% compared to head (866e57c) 99.05%.

Files Patch % Lines
lib/datadog/ci/configuration/settings.rb 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   99.10%   99.05%   -0.05%     
==========================================
  Files         147      147              
  Lines        6269     6276       +7     
  Branches      286      288       +2     
==========================================
+ Hits         6213     6217       +4     
- Misses         56       59       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review January 19, 2024 12:43
@anmarchenko anmarchenko requested review from a team as code owners January 19, 2024 12:43
@anmarchenko anmarchenko merged commit b8ce942 into main Jan 22, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/enable_tslv_by_default branch January 22, 2024 11:40
@github-actions github-actions bot added this to the 0.7.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants