-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIS-8549] better skipped tests and suites support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem as skipped, not passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 98.96% 99.04% +0.07%
==========================================
Files 151 151
Lines 6469 6676 +207
Branches 299 296 -3
==========================================
+ Hits 6402 6612 +210
+ Misses 67 64 -3 ☔ View full report in Codecov by Sentry. |
…e to see if there are some that weren't skipped
…nd is able to derive status based on these stats. Minitest instrumentation correctly marks test suites as skipped.
…success when setting test suite status
nikita-tkachenko-datadog
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solves multiple issues around skipped tests and test suites:
Motivation
Wrapping up last bugs and problems before GA for Ruby
Additional Notes
As Ruby test frameworks mostly do not provide statuses of test suites (and do not care much about the concept of a test suite), now we track count of passed/failed/skipped tests per test suite in
Datadog::CI::TestSuite
object