Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2985] use ruby 2.7 syntax #117

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jan 29, 2024

What does this PR do?
Migrates this library to use Ruby 2.7 syntax: safe navigation operator, filter_map method

Motivation
We don't support older rubies anymore and can simplify some code

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8394cdb) 99.04% compared to head (7512edf) 99.05%.

Files Patch % Lines
lib/datadog/ci/configuration/settings.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #117      +/-   ##
==========================================
+ Coverage   99.04%   99.05%   +0.01%     
==========================================
  Files         152      152              
  Lines        6691     6677      -14     
  Branches      296      295       -1     
==========================================
- Hits         6627     6614      -13     
+ Misses         64       63       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title use ruby 2.7 syntax [CIVIS-2985] use ruby 2.7 syntax Jan 29, 2024
@anmarchenko anmarchenko marked this pull request as ready for review January 29, 2024 15:09
@anmarchenko anmarchenko requested review from a team as code owners January 29, 2024 15:09
@anmarchenko anmarchenko merged commit 110875d into 1.0 Jan 29, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/use_ruby_2.7_syntax branch January 29, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants