Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote library configuration support and ITR::Runner #129

Merged
merged 20 commits into from
Mar 6, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Feb 29, 2024

What does this PR do?

First step for Intelligent Test Runner implementation: implement remote library settings configuration

Main changes:

  • Agentless and EvpProxy api clients support multiple backend endpoints now (citestcycle-intake.dd-site for events and api.dd-site for remote configuration)
  • RemoteSettingsApi client for fetching the remote configuration
  • Datadog::CI::ITR::Runner class that holds ITR configuration
  • Some ITR related tags for test_session_end events: test.code_coverage.enabled, test.itr.tests_skipping.enabled, test.itr.tests_skipping.type
  • when ITR is enabled in local settings, TestVisibility::Recorder fetches remote settings and configures ITR

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (8eb9540) to head (86932a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   99.02%   99.08%   +0.05%     
==========================================
  Files         152      156       +4     
  Lines        6672     7102     +430     
  Branches      299      303       +4     
==========================================
+ Hits         6607     7037     +430     
  Misses         65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review March 5, 2024 14:03
@anmarchenko anmarchenko requested review from a team as code owners March 5, 2024 14:03
@anmarchenko anmarchenko changed the title ITR settings Remote library configuration support and ITR::Runner Mar 5, 2024
"branch" => test_session.git_branch,
"sha" => test_session.git_commit_sha,
"configurations" => {
"os.platform" => test_session.os_platform,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to include os version here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can I see full specification for the request body? os.version was not in the provided example, so I wonder what else I missed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, it turned out that os.version tag is not present both in ruby core tracer and in test tags for CI visibility right now. I will refrain from adding it in this PR as not to change test fingerprints unnecessary and will add this one to backlog to evaluate

@anmarchenko anmarchenko merged commit e016c07 into main Mar 6, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/itr_settings branch March 6, 2024 11:26
@github-actions github-actions bot added this to the 1.0.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants