-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote library configuration support and ITR::Runner #129
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 99.02% 99.08% +0.05%
==========================================
Files 152 156 +4
Lines 6672 7102 +430
Branches 299 303 +4
==========================================
+ Hits 6607 7037 +430
Misses 65 65 ☔ View full report in Codecov by Sentry. |
"branch" => test_session.git_branch, | ||
"sha" => test_session.git_commit_sha, | ||
"configurations" => { | ||
"os.platform" => test_session.os_platform, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to include os version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where can I see full specification for the request body? os.version
was not in the provided example, so I wonder what else I missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, it turned out that os.version
tag is not present both in ruby core tracer and in test tags for CI visibility right now. I will refrain from adding it in this PR as not to change test fingerprints unnecessary and will add this one to backlog to evaluate
What does this PR do?
First step for Intelligent Test Runner implementation: implement remote library settings configuration
Main changes:
Agentless
andEvpProxy
api clients support multiple backend endpoints now (citestcycle-intake.dd-site for events and api.dd-site for remote configuration)RemoteSettingsApi
client for fetching the remote configurationDatadog::CI::ITR::Runner
class that holds ITR configurationTestVisibility::Recorder
fetches remote settings and configures ITR