Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] reenable git specs for jruby and delete useless flaky spec #182

Merged
merged 1 commit into from
May 24, 2024
Merged

[NO-TICKET] reenable git specs for jruby and delete useless flaky spec #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions spec/datadog/ci/contrib/minitest/instrumentation_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,19 +681,6 @@ def test_b_2
expect(first_test_span).to have_test_tag(:test_session_id, test_session_span.id.to_s)
end

it "correctly tracks test and session durations" do
test_session_duration = test_session_span.duration

test_durations_sum = test_spans.map { |span| span.duration }.sum
# with parallel execution test durations sum should be greater than test session duration
expect(test_durations_sum).to be > test_session_duration

# each individual test duration should be less than test session duration
test_spans.each do |span|
expect(span.duration).to be < test_session_duration
end
end

it "creates test suite spans" do
expect(test_suite_spans).to have(4).items

Expand Down
2 changes: 0 additions & 2 deletions spec/datadog/ci/git/local_repository_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ def with_custom_git_environment
end

context "with cloned repository" do
before { skip if PlatformHelpers.jruby? }

let(:commits_count) { 2 }

let(:tmpdir) { Dir.mktmpdir }
Expand Down
Loading