[NO TICKET] test code coverage with symlinked dependency required via entrypoint #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an entrypoint in symlinked folder
anmarchenko
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 98.93% 98.86% -0.08%
==========================================
Files 221 228 +7
Lines 10039 10096 +57
Branches 466 466
==========================================
+ Hits 9932 9981 +49
- Misses 107 115 +8 ☔ View full report in Codecov by Sentry. |
anmarchenko
commented
Jun 3, 2024
| @@ -103,7 +103,7 @@ namespace :test do | |||
| "bundle exec appraisal #{ruby_runtime}-#{appraisal_group} rake #{spec_task}" | |||
There was a problem hiding this comment.
changes in this file are unrelated, just enjoying our own Datadog's static code analysis tool
nikita-tkachenko-datadog
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a test to assert that code coverage tool gets correct file paths when dependencies are located in symlinked folder and required via single entrypoint (emulating usage of local dependencies that are just symlinks to modules in minirepo).
Motivation
Make sure that code coverage won't break in the future as this is known case for the monorepo setup.
How to test the change?
This PR adds only unit tests.