Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-172] Refactor configs and components #196

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Applies some refactorings:

  • splits some code in components.rb in methods to make
  • renames TestVisibility::Recorder to TestVisibility::Component
  • renames ITR to TestOptimisation to make the name more generic
  • renames ITR::Runner to TestOptimisation::Component

Motivation
There are some topics that require attention before adding telemetry to the mix

How to test the change?
Unit tests, no behavior change

@anmarchenko anmarchenko requested review from a team as code owners July 2, 2024 14:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.15966% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.88%. Comparing base (fea0ea2) to head (f8f603b).

Files Patch % Lines
lib/datadog/ci/test_optimisation/component.rb 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         231      231           
  Lines       10359    10368    +9     
  Branches      473      475    +2     
=======================================
+ Hits        10243    10252    +9     
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko merged commit ef4a668 into main Jul 2, 2024
28 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/refactor_configs_and_components branch July 2, 2024 15:10
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants