-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use images from images-rb #198
Conversation
@TonyCTHsu thank you!! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 98.88% 98.87% -0.01%
==========================================
Files 231 231
Lines 10368 10368
Branches 475 475
==========================================
- Hits 10252 10251 -1
- Misses 116 117 +1 ☔ View full report in Codecov by Sentry. |
Should we maybe delete the Dockerfiles in https://github.com/DataDog/dd-trace-rb/tree/master/.circleci/images/primary to avoid any confusion? |
For migration, we can swap out all the images used for unit tests theoretically. But those images are used by integration tests in |
Wait, isn't the integration test images (in CircleCI) what we're changing here? Or do you maybe mean the images we use in |
Update: I totally thought this PR was on the dd-trace-rb repo. My comments make no sense in the scope of datadog-ci-rb. Sorry for the confusion >_> |
What does this PR do?
Use images from images-rb