Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use images from images-rb #198

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Use images from images-rb #198

merged 4 commits into from
Jul 9, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Use images from images-rb

@TonyCTHsu TonyCTHsu requested review from a team as code owners July 9, 2024 11:43
@TonyCTHsu TonyCTHsu requested a review from tonyredondo July 9, 2024 11:43
@anmarchenko
Copy link
Member

@TonyCTHsu thank you!!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (ef4a668) to head (55beaae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   98.88%   98.87%   -0.01%     
==========================================
  Files         231      231              
  Lines       10368    10368              
  Branches      475      475              
==========================================
- Hits        10252    10251       -1     
- Misses        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo
Copy link
Member

ivoanjo commented Jul 9, 2024

Should we maybe delete the Dockerfiles in https://github.com/DataDog/dd-trace-rb/tree/master/.circleci/images/primary to avoid any confusion?

@TonyCTHsu
Copy link
Contributor Author

Should we maybe delete the Dockerfiles in https://github.com/DataDog/dd-trace-rb/tree/master/.circleci/images/primary to avoid any confusion?

For migration, we can swap out all the images used for unit tests theoretically. But those images are used by integration tests in dd-trace-rb. We need to change how we conduct integration tests before deleting those images.

@ivoanjo
Copy link
Member

ivoanjo commented Jul 9, 2024

But those images are used by integration tests in dd-trace-rb.

Wait, isn't the integration test images (in CircleCI) what we're changing here? Or do you maybe mean the images we use in docker-compose.yml for local development?

@ivoanjo
Copy link
Member

ivoanjo commented Jul 9, 2024

Update: I totally thought this PR was on the dd-trace-rb repo. My comments make no sense in the scope of datadog-ci-rb. Sorry for the confusion >_>

@anmarchenko anmarchenko merged commit 579867e into main Jul 9, 2024
28 checks passed
@anmarchenko anmarchenko deleted the tonycthsu/images branch July 9, 2024 14:05
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants