-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDTEST-172] Remote configuration component #210
Merged
anmarchenko
merged 10 commits into
main
from
anmarchenko/remote_configuration_component
Jul 30, 2024
Merged
[SDTEST-172] Remote configuration component #210
anmarchenko
merged 10 commits into
main
from
anmarchenko/remote_configuration_component
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 251 254 +3
Lines 11560 11638 +78
Branches 516 522 +6
==========================================
+ Hits 11427 11504 +77
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
…upload_worker param from TestVisibility::Component
…ttings include flaky test retries and early flake detection
nikita-tkachenko-datadog
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before implementing flaky test retries and early flake detection, I extracted logic for fetching remote library settings in a separate component.
How to test the change?
Unit tests are provided