Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-172] Remote configuration component #210

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jul 30, 2024

What does this PR do?
Before implementing flaky test retries and early flake detection, I extracted logic for fetching remote library settings in a separate component.

How to test the change?
Unit tests are provided

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (03fe65e) to head (1ea8eff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         251      254       +3     
  Lines       11560    11638      +78     
  Branches      516      522       +6     
==========================================
+ Hits        11427    11504      +77     
- Misses        133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review July 30, 2024 14:50
@anmarchenko anmarchenko requested review from a team as code owners July 30, 2024 14:50
@anmarchenko anmarchenko merged commit 0e24d28 into main Jul 30, 2024
28 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/remote_configuration_component branch July 30, 2024 15:42
@github-actions github-actions bot added this to the 1.4.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants