[SDTEST-481] Skip Before/After hooks in cucumber when scenario is skipped by intelligent test runner #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igent test runner
juan-fernandez
approved these changes
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 254 253 -1
Lines 11638 11630 -8
Branches 522 521 -1
==========================================
- Hits 11504 11496 -8
Misses 134 134 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves test skipping by intelligent test runner: if we bail out of test execution early we save more time by skipping before/after hooks that could be expensive
Motivation
I noticed that intelligent test runner does not skip test hooks in cucumber which reduces time saved by skipping tests
How to test the change?
Unit test is adapted to reflect the new behaviour