Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-579] make itr_enabled config parameter true by default #216

Merged
merged 1 commit into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/datadog/ci/configuration/settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def self.add_settings!(base)
option :itr_enabled do |o|
o.type :bool
o.env CI::Ext::Settings::ENV_ITR_ENABLED
o.default false
o.default true
end

option :git_metadata_upload_enabled do |o|
Expand Down
10 changes: 5 additions & 5 deletions spec/datadog/ci/configuration/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def patcher
describe "#itr_enabled" do
subject(:itr_enabled) { settings.ci.itr_enabled }

it { is_expected.to be false }
it { is_expected.to be true }

context "when #{Datadog::CI::Ext::Settings::ENV_ITR_ENABLED}" do
around do |example|
Expand All @@ -234,7 +234,7 @@ def patcher
context "is not defined" do
let(:enable) { nil }

it { is_expected.to be false }
it { is_expected.to be true }
end

context "is set to true" do
Expand All @@ -253,10 +253,10 @@ def patcher

describe "#itr_enabled=" do
it "updates the #enabled setting" do
expect { settings.ci.itr_enabled = true }
expect { settings.ci.itr_enabled = false }
.to change { settings.ci.itr_enabled }
.from(false)
.to(true)
.from(true)
.to(false)
end
end

Expand Down
Loading