Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-865] Send internal vCPU count metric #236

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Sep 20, 2024

What does this PR do?
Sends internal metric _dd.host.vcpu_count for all test visibility events. This metric contains value of the virtual processors that are available to the Ruby process that runs the test suite.

Motivation
It enables Datadog backend to compute the infrastructure cost savings provided by ITR.

How to test the change?
Unit tests are provided.

Tested using middleman on staging (with internal feature flag that show hidden event metadata):
image

@anmarchenko anmarchenko changed the title Anmarchenko/cpu_count_metric [SDTEST-865] Send internal vCPU count metric Sep 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b8f49d9) to head (576529e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         273      273           
  Lines       13368    13381   +13     
  Branches      600      601    +1     
=======================================
+ Hits        13228    13241   +13     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review September 20, 2024 10:40
@anmarchenko anmarchenko requested review from a team as code owners September 20, 2024 10:40
@anmarchenko anmarchenko merged commit 3db15fe into main Sep 20, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/cpu_count_metric branch September 20, 2024 12:37
@github-actions github-actions bot added this to the 1.6.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants