Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-301] add source location info to test suites #239

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Sep 23, 2024

What does this PR do?
Adds test.source.file, test.source.start, test.codeowners tags to test suites reported to Datadog

Motivation
We want to show source locations for test suites and attach codeowners to test suites

How to test the change?
Unit tests are provided

RSpec (tested using rubocop):
image

Minitest (tested using feedbin):
image

Cucumber (tested using middleman):
image

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (f3d84e6) to head (c1fdf81).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         273      273           
  Lines       13381    13404   +23     
  Branches      601      606    +5     
=======================================
+ Hits        13241    13264   +23     
  Misses        140      140           
Flag Coverage Δ
98.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review September 24, 2024 10:34
@anmarchenko anmarchenko requested review from a team as code owners September 24, 2024 10:34
@anmarchenko anmarchenko merged commit 17b2e4f into main Sep 24, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/source_location_for_test_suites branch September 24, 2024 10:42
@github-actions github-actions bot added this to the 1.7.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants