-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDTEST-878] Optimise LocalRepository.relative_to_root helper to make test impact analysis faster #244
Merged
anmarchenko
merged 7 commits into
main
from
anmarchenko/code_coverage_performance_optimisation
Oct 1, 2024
Merged
[SDTEST-878] Optimise LocalRepository.relative_to_root helper to make test impact analysis faster #244
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9d8e7e8
first pass on optimisation of relative_to_root helper
anmarchenko b12f028
optimise .relative_to_root more
anmarchenko 9a24041
provide 0 response size when request failed
anmarchenko 98f03e5
add some comments and additional test case
anmarchenko 22d3cc4
fix failing tests
anmarchenko f6621e8
try to fix tests agasin
anmarchenko 777af47
circle ci runs tests in /app folder
anmarchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,6 +149,10 @@ def code | |
nil | ||
end | ||
|
||
def response_size | ||
0 | ||
end | ||
|
||
def inspect | ||
"ErrorResponse error:#{error}" | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change, I noticed that library started to fail if certain backend API is not available because for ErrorResponse there is no http_response