Bump maximum ruby version to 3.5 #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe resolves #273 depending on tests |
|
Hi! Thanks for your contribution! for some curious reason, GHA for unit tests refuse to appear in your PR, I will investigate it later. For now, I will quickly create a new PR to bump MAXIMUM_RUBY_VERSION |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the MAXIMUM_RUBY_VERSION from 3.4 to 3.5
Motivation
There's an issue asking for Ruby 3.4 to be supported. I'm curious if tests pass with this change.
Additional Notes
How to test the change?
Full regression testing