Datadog::CI.trace_test always starts a new trace #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a session they belong to a single trace
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 99.30% 99.32% +0.02%
==========================================
Files 125 125
Lines 4328 4328
Branches 153 153
==========================================
+ Hits 4298 4299 +1
+ Misses 30 29 -1 ☔ View full report in Codecov by Sentry. |
anmarchenko
changed the title
nikita-tkachenko-datadog
approved these changes
Nov 28, 2023
| @@ -119,6 +122,11 @@ def trace | |||
| end | |||
| end | |||
|
|
|||
| # returns trace associated with given span | |||
| def trace_for_span(span) | |||
| traces.find { |trace| trace.id == span.trace_id } | |||
There was a problem hiding this comment.
Just to double-check: traces contains only currently active traces, right? Asking because of the linear search.
There was a problem hiding this comment.
this one is a spec helper so it is used only in tests to examine the tracer's internal state for our assertions
we never access tracer's state in production like that
marcotc
approved these changes
Nov 28, 2023
anmarchenko
force-pushed
the
anmarchenko/single_trace_per_test
branch
from
3ecfd8d to
a14f853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sure that when tracing a test we always create a new trace by using
continue_fromspan optionMotivation
In order not to break trace view UI we need to be sure that each test receives its own trace
Additional Notes
Unrelated change:
Datadog::CI::Recorderspec is completely rewritten in saner style without endless doubles and expectactionsHow to test the change?
Unit tests are provided