support validation errors for CI spans #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we don't see any feedback when invalid events are being discarded during serialization phase. This behaviour was inherited from ddtrace-rb where such errors are only emitted in debug mode.
For CI visibility library it is very important to report all the spans, so skipping invalid spans is a serious error that requires an action.
What does this PR do?
How to test the change?
Unit tests are provided