[Cucumber contrib] remove tracking failed tests count per test suite, mark test suite as failed if any test fails #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mark test suite as failed if any test fails
ekump
approved these changes
Jan 3, 2024
anmarchenko
changed the title
juan-fernandez
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies test suite failure tracking for Cucumber integration: instead of counting how many tests failed per current test suite, we will mark test suite as failed if any of the tests failed.
This will eliminate additional variable and condition checks that could cause bugs.
Motivation
Making test suite failure tracking for Cucumber simpler and similar to Minitest implementation.
Additional Notes
Tracking failure counts still exists for test session for the following reasons:
How to test the change?
Unit tests stay the same, it is a refactoring without behaviour change