Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to README.md about test suite level visibility feature #97

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Added a note about how to configure experimental test suite level visibility feature to gather early feedback

Motivation
Make this feature more visibile and gather early feedback.

@anmarchenko anmarchenko requested review from a team and juan-fernandez January 5, 2024 11:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b117666) 99.22% compared to head (6122329) 99.22%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         142      142           
  Lines        5920     5920           
  Branches      232      232           
=======================================
  Hits         5874     5874           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
@@ -134,6 +134,30 @@ Datadog.configure { |c| c.ci.agentless_mode_enabled = true }

## Additional configuration

### Experimental test suite level visibility support

Test suite level visibility (TSLV) is available for `datadog-ci`` gem versions 0.6 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a typo?

Suggested change
Test suite level visibility (TSLV) is available for `datadog-ci`` gem versions 0.6 and above.
Test suite level visibility (TSLV) is available for `datadog-ci` gem versions 0.6 and above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is, thank you

README.md Outdated
@@ -134,6 +134,30 @@ Datadog.configure { |c| c.ci.agentless_mode_enabled = true }

## Additional configuration

### Experimental test suite level visibility support

Test suite level visibility (TSLV) is available for `datadog-ci`` gem versions 0.6 and above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I find it somewhat weird to list the minimum version for a feature in the readme, since, well, every feature that gets added is a feature that has a minimum version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very true, I think this info is not needed here

@anmarchenko anmarchenko merged commit f3be528 into main Jan 8, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/experimental_tslv_readme branch January 8, 2024 13:35
@github-actions github-actions bot added this to the 0.7.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants