add additional testing for the stream socket addition

DataDog · Dec 4, 2024 · 1bdc678 · 1bdc678
1 parent e3b82a9
commit 1bdc678
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/tests/integration/dogstatsd/test_statsd_sender.py b/tests/integration/dogstatsd/test_statsd_sender.py
@@ -67,10 +67,8 @@ def test_stream_cleanup():
 
     foo.setsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF, 1) # different os's have different mins, e.g. this sets the buffer size to 2304 on certain linux variants
 
-    try:
+    with pytest.raises(socket.error):
         foo.sendall(os.urandom(5000)) # pre-emptively clog the buffer
-    except BlockingIOError:
-        pass
 
     statsd.increment("test", 1)
 

diff --git a/tests/unit/dogstatsd/test_statsd.py b/tests/unit/dogstatsd/test_statsd.py
@@ -2124,13 +2124,13 @@ def test_fake_sockets(self):
         """
         statsd = DogStatsd(disable_buffering=True)
 
-        class fake_sock:
+        class fakeSock:
             def __init__(self, id):
                 self.id = id
             def send(self, _):
                 pass
-        statsd.socket = fake_sock(5)
-        statsd.telemetry_socket = fake_sock(10)
+        statsd.socket = fakeSock(5)
+        statsd.telemetry_socket = fakeSock(10)
 
         assert statsd.socket.id == 5
         assert statsd.telemetry_socket.id == 10