fix tests

DataDog · Jan 17, 2025 · cd7627e · cd7627e
1 parent 7f8ea80
commit cd7627e
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/tests/unit/dogstatsd/test_max_sample_metrics.py b/tests/unit/dogstatsd/test_max_sample_metrics.py
@@ -12,18 +12,18 @@ def test_new_histogram_metric(self):
         self.assertEqual(s.metric_type, MetricType.HISTOGRAM)
 
     def test_histogram_metric_sample(self):
-        s = HistogramMetric(name="test", tags="tag1,tag2", rate=1.0, max_metric_samples=0)
-        s.sample(123.45)
+        s = HistogramMetric(name="test", tags="tag1,tag2", rate=1.0, max_metric_samples=1)
+        s.maybe_keep_sample(123.45)
         self.assertEqual(s.data, [123.45])
         self.assertEqual(s.name, "test")
         self.assertEqual(s.tags, "tag1,tag2")
         self.assertEqual(s.specified_rate, 1.0)
         self.assertEqual(s.metric_type, MetricType.HISTOGRAM)
 
     def test_flush_histogram_metric_sample(self):
-        s = HistogramMetric(name="test", tags="tag1,tag2", rate=1.0, max_metric_samples=0)
+        s = HistogramMetric(name="test", tags="tag1,tag2", rate=1.0, max_metric_samples=1)
 
-        s.sample(21)
+        s.maybe_keep_sample(21)
         m = s.flush()[0]
         self.assertEqual(m.metric_type, MetricType.HISTOGRAM)
         self.assertEqual(m.value, 21.0)
@@ -39,16 +39,16 @@ def test_new_distribution_metric(self):
         self.assertEqual(s.metric_type, MetricType.DISTRIBUTION)
 
     def test_distribution_metric_sample(self):
-        s = DistributionMetric(name="test", tags="tag1,tag2", max_metric_samples=0, rate=1.0)
-        s.sample(123.45)
+        s = DistributionMetric(name="test", tags="tag1,tag2", max_metric_samples=1, rate=1.0)
+        s.maybe_keep_sample(123.45)
         self.assertEqual(s.data, [123.45])
         self.assertEqual(s.name, "test")
         self.assertEqual(s.tags, "tag1,tag2")
         self.assertEqual(s.metric_type, MetricType.DISTRIBUTION)
 
     def test_flush_distribution_metric_sample(self):
-        s = DistributionMetric(name="test", tags="tag1,tag2", max_metric_samples=0, rate=1.0)
-        s.sample(123.45)
+        s = DistributionMetric(name="test", tags="tag1,tag2", max_metric_samples=1, rate=1.0)
+        s.maybe_keep_sample(123.45)
         m = s.flush()[0]
         self.assertEqual(m.metric_type, MetricType.DISTRIBUTION)
         self.assertEqual(m.value, 123.45)
@@ -62,16 +62,16 @@ def test_new_timing_metric(self):
         self.assertEqual(s.metric_type, MetricType.TIMING)
 
     def test_timing_metric_sample(self):
-        s = TimingMetric(name="test", tags="tag1,tag2", max_metric_samples=0, rate=1.0)
-        s.sample(123.45)
+        s = TimingMetric(name="test", tags="tag1,tag2", max_metric_samples=1, rate=1.0)
+        s.maybe_keep_sample(123.45)
         self.assertEqual(s.data, [123.45])
         self.assertEqual(s.name, "test")
         self.assertEqual(s.tags, "tag1,tag2")
         self.assertEqual(s.metric_type, MetricType.TIMING)
 
     def test_flush_timing_metric_sample(self):
-        s = TimingMetric(name="test", tags="tag1,tag2", max_metric_samples=0, rate=1.0)
-        s.sample(123.45)
+        s = TimingMetric(name="test", tags="tag1,tag2", max_metric_samples=1, rate=1.0)
+        s.maybe_keep_sample(123.45)
         m = s.flush()[0]
         self.assertEqual(m.metric_type, MetricType.TIMING)
         self.assertEqual(m.value, 123.45)