Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing Unix timestamps to dogstatsd #829

Closed
wants to merge 2 commits into from

Conversation

abolibibelot
Copy link
Contributor

@abolibibelot abolibibelot commented Apr 18, 2024

What does this PR do?

Following v1.3 protocol, allow passing timestamps along with the metric, which can mitigate the load on the agent when emitting a lot of metrics in a short time span.

Only gauges and counts are supported.

Description of the Change

Updated gauge, increment and decrement to allow for passing timestamps.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@abolibibelot abolibibelot requested review from a team as code owners April 18, 2024 12:49
Following [v1.3 protocol](https://docs.datadoghq.com/developers/dogstatsd/datagram_shell/?tab=metrics#dogstatsd-protocol-v13) allow passing timestamps along with the metric, which can mitigate the load on the agent when emitting a lot of metrics in a short time span.

Only gauges and counts are supported.
@abolibibelot abolibibelot force-pushed the yartz/add-support-for-ts-in-metrics branch from 2842006 to 656a7f7 Compare April 18, 2024 12:51
@abolibibelot abolibibelot added the changelog/Added Added features results into a minor version bump label Apr 22, 2024
and document minimum agent version.
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label May 30, 2024
@abolibibelot abolibibelot deleted the yartz/add-support-for-ts-in-metrics branch May 30, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants