Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(origin detection): implement new spec #839

Merged

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Jul 3, 2024

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@wdhif wdhif requested review from a team as code owners July 3, 2024 11:54
@wdhif wdhif marked this pull request as draft July 3, 2024 11:54
@wdhif wdhif added the changelog/no-changelog Changes don't appear in changelog label Jul 3, 2024
@wdhif wdhif force-pushed the CONTP-20/wassim.dhif/implement-new-origin-detection-spec branch from d138b82 to 6d4d78d Compare July 8, 2024 12:26
@wdhif wdhif changed the title feat(origin detection): implement local data feat(origin detection): implement new spec Jul 8, 2024
@wdhif wdhif force-pushed the CONTP-20/wassim.dhif/implement-new-origin-detection-spec branch 2 times, most recently from b0ccc94 to 43088cf Compare July 19, 2024 14:50
@wdhif wdhif force-pushed the CONTP-20/wassim.dhif/implement-new-origin-detection-spec branch from 43088cf to af999ef Compare July 19, 2024 14:53
@wdhif wdhif marked this pull request as ready for review July 22, 2024 08:58
@wdhif
Copy link
Member Author

wdhif commented Jul 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 24, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 0s.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Jul 24, 2024

MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch 'master' is 120 minutes.

If you need support, contact us on Slack #devflow with those details!

@wdhif
Copy link
Member Author

wdhif commented Jul 25, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 0s.

Use /merge -c to cancel this operation!

@wdhif wdhif merged commit 3f674b2 into master Jul 25, 2024
33 checks passed
@wdhif wdhif deleted the CONTP-20/wassim.dhif/implement-new-origin-detection-spec branch July 25, 2024 08:09
@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 MergeQueue: This merge request was already merged

This pull request was merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants