Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins and Versions Refactor #5015

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Dec 14, 2024

  • consolidate instances of loadInst, so code isn't repeated

Copy link

github-actions bot commented Dec 14, 2024

Overall package size

Self size: 8.3 MB
Deduped: 94.6 MB
No deduping: 95.12 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@bengl bengl force-pushed the bengl/refactor-plugins-and-ranges branch from 2c03826 to 432f4a7 Compare December 14, 2024 03:30
@pr-commenter
Copy link

pr-commenter bot commented Dec 14, 2024

Benchmarks

Benchmark execution time: 2024-12-16 18:10:27

Comparing candidate commit 2a62556 in PR branch bengl/refactor-plugins-and-ranges with baseline commit baf22d9 in branch master.

Found 0 performance improvements and 13 performance regressions! Performance is the same for 764 metrics, 21 unstable metrics.

scenario:appsec-iast-no-vulnerability-control-18

  • 🟥 cpu_user_time [+35.924ms; +47.461ms] or [+6.029%; +7.965%]
  • 🟥 execution_time [+40.821ms; +60.632ms] or [+5.281%; +7.844%]
  • 🟥 instructions [+98.5M instructions; +106.4M instructions] or [+6.737%; +7.278%]

scenario:appsec-iast-no-vulnerability-control-20

  • 🟥 cpu_user_time [+37.345ms; +50.769ms] or [+6.571%; +8.933%]
  • 🟥 execution_time [+43.508ms; +64.118ms] or [+6.194%; +9.129%]
  • 🟥 instructions [+108.0M instructions; +118.0M instructions] or [+8.409%; +9.183%]

scenario:appsec-iast-no-vulnerability-control-22

  • 🟥 cpu_user_time [+36.170ms; +48.556ms] or [+7.042%; +9.454%]
  • 🟥 instructions [+112.8M instructions; +120.7M instructions] or [+8.465%; +9.056%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-22

  • 🟥 cpu_user_time [+75.459ms; +93.311ms] or [+7.158%; +8.851%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-22

  • 🟥 cpu_user_time [+78.647ms; +100.906ms] or [+7.769%; +9.968%]
  • 🟥 execution_time [+68.360ms; +124.798ms] or [+5.747%; +10.491%]
  • 🟥 instructions [+128.1M instructions; +146.5M instructions] or [+5.308%; +6.071%]

scenario:appsec-iast-with-vulnerability-control-22

  • 🟥 instructions [+110.0M instructions; +126.4M instructions] or [+5.443%; +6.250%]

@bengl bengl force-pushed the bengl/refactor-plugins-and-ranges branch 3 times, most recently from e250dc4 to 8e97cfa Compare December 14, 2024 19:47
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (823cfd4) to head (88f4f36).
Report is 39 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5015       +/-   ##
===========================================
+ Coverage   65.05%   75.94%   +10.89%     
===========================================
  Files         304       21      -283     
  Lines       13950      977    -12973     
===========================================
- Hits         9075      742     -8333     
+ Misses       4875      235     -4640     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bengl bengl force-pushed the bengl/refactor-plugins-and-ranges branch 2 times, most recently from 3ed1682 to e81e0de Compare December 14, 2024 20:02
@bengl bengl force-pushed the bengl/refactor-plugins-and-ranges branch 4 times, most recently from 88f4f36 to d805553 Compare December 16, 2024 17:30
@bengl bengl force-pushed the bengl/refactor-plugins-and-ranges branch from d805553 to 2a62556 Compare December 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant