[SDTEST-756] add +ci-X.Y.Z to the tracer_version reported to internal telemetry if datadog-ci is present and CI mode is enabled #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
anmarchenko
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3881 +/- ##
========================================
Coverage 97.87% 97.87%
========================================
Files 1277 1279 +2
Lines 76392 76521 +129
Branches 3744 3747 +3
========================================
+ Hits 74766 74893 +127
- Misses 1626 1628 +2 ☔ View full report in Codecov by Sentry. |
ivoanjo
reviewed
Sep 3, 2024
BenchmarksBenchmark execution time: 2024-09-06 14:44:01 Comparing candidate commit 72702ff in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - estimated profiler gc per minute (sample 60000 times + serialize result)
scenario:profiler - profiler gc
|
|
Does this PR not need any test coverage? |
anmarchenko
force-pushed
the
anmarchenko/report_tracer_version_for_telemetry_with_ci
branch
from
eb1e504 to
f44f8b1
Compare
y9v
approved these changes
Sep 6, 2024
anmarchenko
deleted the
anmarchenko/report_tracer_version_for_telemetry_with_ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed before, we will extend tracer_version reported for internal telemetry with datadog-ci gem version if tracing is running in CI mode.
The monkey patch should be removed in the next release: DataDog/datadog-ci-rb#228
Motivation:
We need a better solution to distinguish datadog-ci versions when examining telemetry metrics emitted from the datadog-ci gem.
Additional Notes:
The original idea with
+ci-X.Y.Zdoesn't work perfect - it gets replaced by_:-ci-X.Y.Zworks fine though:How to test the change?
Tested using staging (see reported tracer versions above). I didn't add unit tests because it would require bringing datadog-ci in appraisals which would be an overkill.