Skip to content

Commit

Permalink
Fix stall detector to be correct threshold (#628)
Browse files Browse the repository at this point in the history
The final expected runtime, is supposed to be whatever we get
from the `threshold` call.

If we add the `max_expected_time` again, it will be wrong.
  • Loading branch information
tontinton authored Dec 3, 2023
1 parent a315d9c commit 328b3b6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions glommio/src/executor/stall.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ pub trait StallDetectionHandler: std::fmt::Debug + Send + Sync {
fn threshold(
&self,
_queue_handle: TaskQueueHandle,
max_expected_runtime: Duration,
_max_expected_runtime: Duration,
) -> Option<Duration> {
Some(max_expected_runtime + Duration::from_millis(10))
Some(Duration::from_millis(10))
}

/// What signal number to use; see values in libc::SIG*.
Expand Down

0 comments on commit 328b3b6

Please sign in to comment.