Add Standard Lint #1
Conversation
TonyCTHsu
commented
May 6, 2024
TonyCTHsu
commented
- Add Standard Lint
- Update gemspec and lint target version to 2.5
- Add Github action for linting
| 'rubygems_mfa_required' => 'true', | ||
| 'source_code_uri' => 'https://github.com/lloeki/graft', | ||
| s.name = "graft" | ||
| s.version = "0.1.0" |
There was a problem hiding this comment.
Typically a case where I feel a rule makes the code less readable.
| @@ -119,11 +119,11 @@ def wrapper(hook) | |||
| strategy: hook.point.instance_variable_get(:@strategy), | |||
| args: args, | |||
| kwargs: kwargs, | |||
| block: block, | |||
| block: block | |||
There was a problem hiding this comment.
That one is soooo annoying: every time you add an item it's making a diff on two lines.
| } | ||
| supa = proc { |*args, &block| super(*args, &block) } | ||
| mid = proc { |_, env| { return: supa.call(*env[:args], &env[:block]) } } | ||
| mid = proc { |_, env| {return: supa.call(*env[:args], &env[:block])} } |
There was a problem hiding this comment.
Very personal, but my mind just balks at these. It's kind of strange because arrays don't cause me such a reaction.
Maybe that's because arrays are <delimiter><value>, <value><delimiter> and it parses easily, whereas hashes are <delimiter><key>: <value>, <key>, <value><delimiter> which binds the <delimiter> and the <key> in a single token.
There was a problem hiding this comment.
That said:
irb> {:a=>:b, :c=>:d}.inspect
=> "{:a=>:b, :c=>:d}"
|
|
||
| gem 'rake', '~> 13.1.0' | ||
| gem "rake", "~> 13.1.0" |
There was a problem hiding this comment.
I'm annoyed by this one, because it misses something very real happening:
# frozen_string_literal: true
a = "foo"
a.frozen? # => true
b = "bar #{a}"
b.frozen? # => false
IOW the rule that makes it so ' is used only when there's interpolation indirectly translates to imply ' is a frozen string and " is not.
Also, " requires a shift while ' does not.
