Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @disabled with @enabled #15

Closed
wants to merge 1 commit into from
Closed

Conversation

TonyCTHsu
Copy link
Contributor

No description provided.

@TonyCTHsu TonyCTHsu requested a review from lloeki as a code owner May 10, 2024 09:45
@TonyCTHsu TonyCTHsu changed the title Replace @disabled with @enabled Replace @disabled with @enabled May 10, 2024
Base automatically changed from tonycthsu/rspec to main May 10, 2024 14:39
Comment on lines 40 to 42
def disabled?
@disabled
!enabled?
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove disabled? altogether.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/toggle-disable branch from 5e91938 to 0e428d4 Compare May 13, 2024 12:12
@lloeki
Copy link
Member

lloeki commented May 13, 2024

@TonyCTHsu This is superseded by #14, right?

@TonyCTHsu
Copy link
Contributor Author

Obsolete

@TonyCTHsu TonyCTHsu closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants