-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several docs #23
Add several docs #23
Conversation
README.md
Outdated
![Gem Version](https://img.shields.io/gem/v/graft?style=for-the-badge&logo=rubygems) | ||
![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/Datadog/graft-rb/test.yml?style=for-the-badge&logo=github) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't find those useful, and in fact misleading:
- last version is on the right side (or it should be once we have release pages in GitHub, which we should), plus it doesn't reflect the actual commit shown
- test result is not the one for the current commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last version is on the right side (or it should be once we have release pages in GitHub, which we should), plus it doesn't reflect the actual commit shown
It shown the last version released on Rubygems.org. I don't mind if we have release pages in GitHub.
test result is not the one for the current commit
I can add branch as parameters.
4bcc93f
to
e997bc9
Compare
What
Code of ConductAdditionally,