-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_powerpacks] Implement support for live span and more widgets #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashashifrina
force-pushed
the
dasha.shifrina/powerpacks-pt-2
branch
from
October 24, 2023 21:12
d06c5ca
to
9dd1332
Compare
dashashifrina
changed the title
support for event stream and trace service, live span for widgets
[datadog_powerpacks] Implement support for live span and more widgets
Oct 24, 2023
dashashifrina
force-pushed
the
dasha.shifrina/powerpacks-pt-2
branch
from
October 25, 2023 15:42
7e9f179
to
7b3551d
Compare
woodb
reviewed
Oct 31, 2023
woodb
previously approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
skarimo
dismissed stale reviews from woodb and buraizu
November 3, 2023 13:30
The base branch was changed.
nkzou
reviewed
Nov 6, 2023
nkzou
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the second part of the support for the powerpack resource in Terraform.
Previous PR:
Changes
live_span
in powerpack. In regular dashboard widgets,live_span
is set at the widget level NOT resource level. For example,event_stream
andtrace_service
widgets uselive_span
, within a powerpack, we setlive_span
under thegroup_widget
object instead. With these changes, users will be redirected to set alive_span
property at the powerpack resource level if they attempt to set it at the widget level.request
LIST property (note: there are some widgets that definerequest
as a single value and will be handled in a follow up)custom_link
LIST propertyHow to test: