Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_logs_pipelines_order] Add datasource for Logs Pipelines Order #2732

Merged

Conversation

LorisFriedel
Copy link
Member

@LorisFriedel LorisFriedel commented Dec 18, 2024

This PR adds a new datasource data.datadog_logs_pipelines_order providing a way to get the current order of logs pipelines in the organisation.

It may be useful in cases where one would want to have pipelines define both inside and outside the Terraform state while still having a way to enforce a specific order amongst all pipelines through Terraform (e.g. pinning the most important pipelines at the top).

OBSPLTF-170

@LorisFriedel LorisFriedel requested review from a team December 18, 2024 23:17
@LorisFriedel LorisFriedel requested review from a team as code owners December 18, 2024 23:17
pablito-perez
pablito-perez previously approved these changes Dec 19, 2024
d33d33
d33d33 previously approved these changes Dec 19, 2024
brett0000FF
brett0000FF previously approved these changes Dec 19, 2024
nhinsch
nhinsch previously approved these changes Dec 19, 2024
Copy link

@nhinsch nhinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LorisFriedel LorisFriedel requested a review from a team December 20, 2024 10:11
Prepager
Prepager previously approved these changes Dec 20, 2024
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr looks great overall. Could you add an example in examples/data-sources and regenerate the docs.

@amaskara-dd amaskara-dd changed the title [data_source_datadog_logs_pipelines_order] Add datasource for Logs Pipelines Order [datadog_logs_pipelines_order] Add datasource for Logs Pipelines Order Jan 3, 2025
@LorisFriedel
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-03 14:31:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 1m.


2025-01-03 14:33:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 83b31f6 into master Jan 3, 2025
18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the loris.friedel/add-data-source-logs-pipelines-order branch January 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants