Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_aws_account] Update docs to clarify required fields and defaults #2748

Merged

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Jan 2, 2025

Prompted by #2734

Adds more description to blocks to indicate which are required, and which may be left empty to use Datadog-assigned default values. Also adds an example config that provides minimum required fields and leverages all pre-set defaults.

@ktmq ktmq requested review from a team as code owners January 2, 2025 18:26
amaskara-dd
amaskara-dd previously approved these changes Jan 2, 2025
buraizu
buraizu previously approved these changes Jan 2, 2025
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a few minor suggestions for consistency

docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
@ktmq ktmq dismissed stale reviews from buraizu and amaskara-dd via b5606de January 2, 2025 19:02
@amaskara-dd amaskara-dd merged commit ac5d614 into master Jan 2, 2025
10 checks passed
@amaskara-dd amaskara-dd deleted the katie.mckew/awscustexp-170-fix-required-attributes-docs branch January 2, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants