[datadog_monitor_json] Fix erroneous drift on restriction_policy field #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Restriction policies are not returned in the API response by default | ||
| // In order to prevent some erroneous drift, we return it (and take in account in the state) | ||
| // if the user requests some restriction policy (behavior similar to Optional Computed) | ||
| if _, ok := attrMap["restriction_policy"]; ok { |
There was a problem hiding this comment.
in addition to concern Phillip raised, couple of things to consider here
- if restricted_roles exist, we should not return restriction policy and vice versa
- we perform sorting on the restriction policy value that is returned, so you would have to take that into consideration as that may not be the same order in which the user defined restriction policy in their terraform file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2515
The /api/v1/monitor/{id} doesn't returns the restriction_policies by default so if the user requests some, there is some unexpected drift.
With this PR, we are requesting the
restriction_policyfield if it is defined in the json submitted by the user.