Skip to content

Commit

Permalink
combo based hidden
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidBeh committed Nov 25, 2024
1 parent 67e1c73 commit a27c51d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions osu.Game.Rulesets.Osu/Mods/OsuModHidden.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private void applyHiddenState(DrawableHitObject drawableObject, bool increaseVis
sliderRepeat.CirclePiece.FadeOut(fadeDuration);

using (drawableObject.BeginAbsoluteSequence(drawableObject.HitStateUpdateTime))
sliderRepeat.FadeOut();
sliderRepeat.FadeOut(fadeDuration);

break;

Expand Down Expand Up @@ -252,7 +252,7 @@ public override void ApplyToScoreProcessor(ScoreProcessor scoreProcessor)
{
scoreProcessor.Combo.ValueChanged += combo =>
{
fadeDurationFactor = combo.NewValue == 0f ? 1f : 1f - (float)combo.NewValue / 20f;
fadeDurationFactor = combo.NewValue == 0f ? 1f : 1f - (float)combo.NewValue / 25f;

Check failure on line 255 in osu.Game.Rulesets.Osu/Mods/OsuModHidden.cs

View workflow job for this annotation

GitHub Actions / Code Quality

Cast is redundant. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0004)

Check failure on line 255 in osu.Game.Rulesets.Osu/Mods/OsuModHidden.cs

View workflow job for this annotation

GitHub Actions / Code Quality

Cast is redundant. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0004)
fadeDurationFactor = Math.Clamp(fadeDurationFactor, 0f, 1f);
};
}
Expand Down

0 comments on commit a27c51d

Please sign in to comment.