uninstalled pass gets locally deleted #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NachE @alexandernst ready for review. anything I missed? may I quickly ask you to see the async code? not very confident here... |
NachE
reviewed
Aug 22, 2024
|
@NachE @alexandernst can above threads get marked as resolved? what else needs to be done to get read-to-merge state? |
|
I think we're good to go! @patroqueeet wanna do the honors and merge? |
|
@NachE @alexandernst merged. should we push a new version? |
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when Apple APNS service returns 410 while trying to send a push notification, our local db might be outdated. hence we must delete the local registration.
addresses #38