load movies/series details from an external api

[sushma-priyadharssini]

loads movie/series details from the suggested api (https://www.tvmaze.com/api). This needs the npm package 'request'.

[KenavR]

I am going to look at it in the morning (midnight here), but just as a side note since I merged your last PR, you need to update your fork.

Sync Fork (Lanflix Master with your Master)

https://help.github.com/articles/syncing-a-fork/

Update branch

https://stackoverflow.com/questions/3876977/update-git-branches-from-master

Otherwise your PR has conflicts (since the /movies/:id route is not part of your branch).

[sushma-priyadharssini]

Yeah.. Sure. I'll update. Thanks, Sushma Priyadharssini KV

…

On Wed, Oct 3, 2018, 3:21 AM KenavR ***@***.***> wrote: I am going to look at it in the morning (midnight here), but just as a side note since I merged your last PR, you need to update your fork. Sync Fork (Lanflix Master with your Master) https://help.github.com/articles/syncing-a-fork/ Update branch https://stackoverflow.com/questions/3876977/update-git-branches-from-master Otherwise your PR has conflicts (since the /movies/:id route is not part of your branch). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWYabNk4kAoL0LsS17ZcrgNHJR5X4m7Uks5ug9_1gaJpZM4XEuZ1> .

[KenavR]

@sushma-priyadharssini Thanks for updating it.

The idea here was to load the video files from the filesystem (#19) take the name of the found movie/series/episode, load the corresponding data from tvmaze (#20), puts both together and stores it to the database (#21, #22). To achieve that we need a service or something that has a function taking a name of a show (we may need the same for movies) and returns the data coming back from the API.

My suggestion would be to create a new service e.g. tvmaze.service.js similar looking to https://github.com/DevvitIO/Lanflix/blob/master/back-end/services/mongo.service.js that provides a function called something like loadDataByName in which you pass the name, request the data and return it. Rough "sketch":

    var TVMazeService = {
        loadDataByName: loadDataByName
    }

    function loadDataByName(showName, callback) {
        request.get("http://api.tvmaze.com/search/shows?q="+ showName, (error, response, body) => {
            if(error) {
                callback(error);
            } else {
                callback(undefined, body);
            }
        });
    }

Now whenever someone wants to load data from the TVMaze api (like in your REST controller), they can use the service like

    TVMazeService.loadDataByName("The Office", (error, data){
        if(error) { console.dir(error); }
        else {
            // Do something with the data e.g. returning it in a response
        }
    });

If you feel comfortable with Promises you can also use those rather than the callbacks from my example above.

---

I am happy to use the request package if that's what you feel most comfortable with but have you looked at the fetch api, this will most likely be the native API in the future. Anyway, we could also change that in the future if necessary.

PS: I saw that the dependencies need updating (security issues), I will do that now, which means you may need to update your fork/branch again.

[sushma-priyadharssini]

Thanks. I have pushed my changes with the above mentioned suggestions. (Created new service-TVMazeService using node-fetch and also used promise objects wherever required)

[joshuaGlass808]

Should this be a const?

[KenavR]

Yes, this could be a const, but that's not a deal breaker.

[joshuaGlass808]

Also out of curiousity, why not use let?

[KenavR]

Could also be a constant, since it doesn't get modified. In the beginning, I tried to keep it ES5 only, but looking at the project currently, it already is a mix between var and const/let maybe someone will go through it in the future and update them.

[KenavR]

Thanks, looks great, sorry for taking so long reviewing it, it's kinda a busy time for me currently.