Start of a fix for BW's biome-related rituals #153
Conversation
|
Oddities noted: Biomes aren't saved 100% of the time, or even in the right size of a radius. |
This reverts commit 26eebfa.
|
Alright, this seems to work as intended, but in order for one to see the changes, one must relog from a world, or trigger a block update. The biomes seem to be sticking, which is good. |
|
Shifting seasons seems to be fine with the packet on servers. However, blighted lands craps itself. |
|
Fixed blighted lands. Though I suppose it would crap itself regardless, when you're looking for a lot of blocks to convert at once. |
|
I'm honestly not too fond of this code, but if anyone thinks they can do better, feel free to do so. |
| @Pseudo | ||
| @Mixin(RitualBiomeShift.class) | ||
| public class MixinRitualBiomeShift { | ||
| @Overwrite(remap = false) |
There was a problem hiding this comment.
are you sure you want to overwrite here? There's definitely a better way.
you could inject at INVOKE, shift to Shift.AFTER and set the target to the descriptor setBiome, and just add
world.getMinecraftServer().getPlayerList().getPlayers().forEach(p -> p.connection.sendPacket(new SPacketChunkData(world.getChunk(effectivePos), 65535)));
This will inject right after setBiome, which is the only place required to inject.
There was a problem hiding this comment.
Any examples of injection in the code of this mod itself? Fairly new to toying with mixins.
There was a problem hiding this comment.
until now I've only seen overwrites(which is probably not a good sign) in jeid.
I do have a cheat sheet about mixins, which you can refer to.
https://github.com/BoogieMonster1O1/mixincs-updated/blob/master/README.md
You'd want to look at @At.
|
As per discussion in the discord, this needs a bit more work added on to fully fix it, as I cannot invest more time into this myself. |
The TC code was fairly identical to what I pretty much needed. Still has a few minor things that need to be worked out, but I'm confident you guys can do that.
Works on servers.
What's needed:
Clean up the gradle. The gradle is a byproduct of how I had to bypass some bugs with it, currently, as well as some frustrations.
Biomes changed by shifting seasons need to refresh. The change is registered, but unless one does something like break a block, or log in and out, the color does not change. This does not happen with the blighted lands ritual for some reason. This most likely can be remedied via a class that alters the biome changing packet BW has. I'm not afraid of any hax.
Alter setMultiBiome
Alter setBiome further
Alter the packet for biome changing
If accepted, please improve on this.
https://github.com/Um-Mitternacht/Bewitchment/blob/1.12.2/src/main/java/com/bewitchment/common/network/PacketChangeBiome.java
https://github.com/Um-Mitternacht/Bewitchment/blob/1.12.2/src/main/java/com/bewitchment/common/world/BiomeChangingUtils.java