Fix mod incompatibility with mods that redirect generateChunk. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify a bit, the problem was exposed because we're trying to continue to prune our overwrites to a minimum (as overwrites add a lot more maintenance on our end and have burned us badly in the past when moving between Minecraft major versions). SpongeForge redirects the generateChunk call and so do you folks but we happen to have a higher priority so yours gets removed from being called. This addresses this so that both mods are happy. |
|
Found a possible issue, one sec (don't merge quite yet). |
Since NotEnoughIDs isn't changing generateChunk and, instead, is only changing the biome array, we can safely inject afterwards. Addresses incompatibility with SpongeForge. Signed-off-by: Chris Sanders <[email protected]>
|
There we go, good to go now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NotEnoughIDs isn't changing generateChunk and, instead, is only
changing the biome array, we can safely inject afterwards.
Addresses incompatibility with SpongeForge.
Signed-off-by: Chris Sanders [email protected]