Inline SVG support #106
Merged
Inline SVG support #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
inline-svg
branch
from
84b80b6 to
5c3fffd
Compare
This support is currently "hacked" by serializing the DOM to string before parsing with usvg. In future we should implement SVG rendering directly from the DOM.
nicoburns
force-pushed
the
inline-svg
branch
from
5c3fffd to
cbe8640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly hacky approach which serializes SVG subtrees of the DOM to string before parsing that string with usvg. But it gets us minimal support quickly.