Disable feature and GPA calculation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By clicking on the menu item (aka browser action), you can now enable or disable the display of grades. I might be able to add functionality to automatically reload any open Schoology pages when disabling/enabling the extension.
I've also implemented the GPA system using the pre-existing
value()function. It displays your average GPA, along with GPA at the side of each course. I removed the multiplying by 0.5 for "CSD" (what is this?) and "Programming" classes because that doesn't represent the actual GPA and makes averaging harder. However, I'm sure there is a reason it was there, so I'll try to find a workaround if you ask.I've kept my changes consistent with the current coding style, but I'd recommend using ES6 arrow functions and
const/letvariable declarations, especially since the codebase already uses ES6 classes.If you're okay with merging but don't like a particular change, please let me know and I'll revert something. Thanks for making this awesome extension!