Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checks] use more accurate errors #74

Merged
merged 3 commits into from
Jan 31, 2025
Merged

[Checks] use more accurate errors #74

merged 3 commits into from
Jan 31, 2025

Conversation

GuillaumeDSM
Copy link
Member

No description provided.

@GuillaumeDSM GuillaumeDSM requested a review from Herklos January 30, 2025 13:02
@GuillaumeDSM GuillaumeDSM self-assigned this Jan 30, 2025
@GuillaumeDSM GuillaumeDSM changed the title WIP [Checks] use more accurate errors [Checks] use more accurate errors Jan 31, 2025
@GuillaumeDSM
Copy link
Member Author

up with tests

Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -61,6 +62,169 @@ async def test_is_valid_account(default_exchange):
_inner_is_valid_account_mock.assert_called_once()


@pytest.mark.asyncio
async def test_get_api_key_rights_using_order(default_exchange):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@GuillaumeDSM GuillaumeDSM merged commit 8f97250 into master Jan 31, 2025
6 checks passed
@GuillaumeDSM GuillaumeDSM deleted the error_management branch January 31, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants