Document the export_v4l2_param_xml tool #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbegani Can you please review this |
lbegani
reviewed
Apr 23, 2018
| The *Camera Definition Files* can be hosted anywhere that is accessible to clients (including *QGroundControl* and Dronecode SDK apps). Often the files are served from the computer running CSD. | ||
|
|
||
| CSD is able to supply the URIs for attached cameras using a mapping given in the [CSD Configuration File > \[uri section\]](../guide/configuration_file.md#uri). | ||
|
|
||
| This topic explains how to: | ||
| * Serve the definition files on the CSD companion computer. | ||
| * Map attached cameras to their definition file URIs in the CSD configuration file. | ||
|
|
||
| > **Tip** Camera definition files for a number of cameras are provided in [/samples/def](https://github.com/intel/camera-streaming-daemon/tree/master/samples/def). | ||
| * Create *Camera Definition Files* for attached Video4Linux (V4L2) devices using the *export_v4l2_param_xml* tool. |
There was a problem hiding this comment.
Please check if the sentence proposed below sound better
Create Camera Definition Files for attached Video4Linux (V4L2) devices using the export_v4l2_param_xml tool
Create Camera Definition Files for Video4Linux (V4L2) camera devices attached to linux machine using the export_v4l2_param_xml tool
There was a problem hiding this comment.
The fact that it is Linux is implied by the Video4Linux API, and we say "attached". That said, I have improved this a bit:
Additionally, the export_v4l2_param_xml tool can automatically generate definition files for attached Video4Linux (V4L2) camera devices.
lbegani
reviewed
Apr 23, 2018
en/guide/camera_definition_file.md
Outdated
| ## V4L2 Camera Definition File Generator {#export_v4l2_param_xml} | ||
|
|
||
| The CSD project includes the *export_v4l2_param_xml* tool to automate creation of *Camera Definition Files* for attached Video4Linux (V4L2) devices. | ||
| The tool queries the device for all available settings in order to populate the file. |
lbegani
reviewed
Apr 23, 2018
en/guide/camera_definition_file.md
Outdated
| ./export_v4l2_param_xml -d <device node> - f <output camera-def-file-name> | ||
| ``` | ||
| where: | ||
| * `device node`: The V3L2 device (query available devices on the command line using: `ls -l /dev/video*`). |
|
Thanks @lbegani ! I've fixed the suggestions and will now merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds instructions on how to build and use the tool introduced in Dronecode/camera-manager#147
After this is merged, I hope to link to it from Mavlink: https://mavlink.io/en/protocol/camera_def.html
... though that would be better if a binary release: Dronecode/camera-manager#165