Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-blocking call to load MyT #293

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

ajain-93
Copy link
Contributor

Load MyT using a non-blocking call in accordance with https://developers.home-assistant.io/docs/asyncio_blocking_operations/#open.

Solves #268 & #271

ajain-93 and others added 2 commits August 21, 2024 20:36

Verified

This commit was signed with the committer’s verified signature.
ivangabriele Ivan Gabriele
Load MyT using a non-blocking call in accordance with https://developers.home-assistant.io/docs/asyncio_blocking_operations/#open.
@CM000n
Copy link
Collaborator

CM000n commented Aug 21, 2024

LGTM. But Code Linting job failed. Please have a look at it.

@ajain-93
Copy link
Contributor Author

This is new to me. Checking out poetry now. Will get back to you.

@ajain-93
Copy link
Contributor Author

I think the latest commit should resolve the linting issues.

@CM000n CM000n merged commit ce06bf8 into DurgNomis-drol:master Aug 23, 2024
5 checks passed
@ajain-93 ajain-93 deleted the non-blocking-load-myt branch August 23, 2024 06:20
@ajain-93 ajain-93 restored the non-blocking-load-myt branch August 23, 2024 06:20
@ajain-93 ajain-93 deleted the non-blocking-load-myt branch August 23, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants