-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Blur support Android & Ios. #993
base: main
Are you sure you want to change the base?
Conversation
It is not working for me. |
@cygnet-umshah I am using it in an application that I have brought live. I have verified that it is successful in real device and simulator tests. On which device did you try it? Can you do a test with the fork I created, in order to reach a definite conclusion? (Main branch)
Delete and reinstall pods for ios. |
I did the same and actually I forked library and then merge your PR into it but blur radius does not working. I am using ProgressiveFastImage so FastImage along with animated. also try without that as well still no behavior change. I need my background to be blur. Android solution works fine but not iOS. |
I will check and also get back to you |
Hello, you are right. I haven't tested this in a project where I use typescript. I think there was a problem with the version of bob builder. I downgraded the package and tested it. You shouldn't encounter a typescript error right now. Can you try again when you have time?
|
I just tried again and it doesn't work, I get the same error as above |
is this working yet? |
I am currently using this repository in my 2 projects that are live. I couldn't reproduce the typescript error mentioned above in my local. I only have one idea for this. If you try to install a package using 'yarn' in the project in any github repository it is a known bug that it ignores some fields contained in 'package.json'. The above issue may be caused by this. (NOTE: This does not apply to Yarn Berry.) Here is the topic; yarnpkg/yarn#2822 @vinnyA3 If you are using npm, pnpm or yarn/berry in your project, can you try installing from here?
If you have the same error, I will try to solve the typescript problem of the pull request. |
Interesting 🤔 @HyopeR -- okie, thanks for this feature request by the way - I am looking to try in one of my projects, and will most likely try a patch here. That said, I'll be happy to see if I can reproduce this error on a clean project. I'll use different versions of yarn, as well as npm, to see. |
It's working for me! Using Expo Dev Client and TypeScript. Thanks a million @HyopeR |
@JoeDareZone I'm glad it worked. Thanks for testing. |
that's can not apply RN version. 68.2 |
@Tchaikovsky1114 What do you mean? Blur feature not working on React Native 0.68.2+? Or do I have a different compilation problem? |
@HyopeR I have issue with your fork [!] CocoaPods could not find compatible versions for pod "SDWebImageWebPCoder": In Podfile: You have either:
|
@Rowb I use the main branch in my fork for my own projects. If you have tried this branch, it is natural that various dependencies have been updated. This pull request was made with the feature/blur fork. There are no dependency changes in this fork. If you are working with the main branch, update your dependencies. |
Hello everyone.
I recently had to develop a blur for this package in a project that works on both platforms.
There were several pull requests and issues opened for this, but none of them were fully completed.
Usage example
Related pull requests
#591 #531 #157
Related issues
#127 #827 #801 #726 #604 #50
Outputs