-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement "Big Bags" #4548
base: master
Are you sure you want to change the base?
Conversation
6eebfc7
to
df746dd
Compare
Thousands of players who don't follow server code, just got a semi...and they don't yet know why. |
Looking good now. |
I have also been doing some testing and wonder if the swapitem, or actually the UpdateInventorySlot should be reworked given the increase bag size. It currently pushes out a db query for each slot in the bag, everytime a bag is selected. For example, if you have a 100 slot bag, and simply click it to place it on the cursor, there will be 100 db queries. 100 more when you place it back in an inventory slot. I wonder if we should batch that instead. This is how master functions, even with a 10 bag slot. I will continue to do some testing. Well done Kingly. Will be a welcome update. |
Every query interaction will definitely need to be done in bulk. This feature lends itself to performance issues by nature so we will need to make sure its solid out of the gate. |
Description
200
slots for ROF2 clients.Disclaimer
10
bag slots so their servers still function properly.Type of change
Before and After Slot IDs
Testing
Clients tested: ROF2
Checklist
version.h
CURRENT_BINARY_DATABASE_VERSION
to the new version.Credits