timelock optimization #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodysalem
requested changes
Jan 1, 2024
moodysalem
requested changes
Jan 8, 2024
moodysalem
reviewed
Jan 11, 2024
src/timelock.cairo
Outdated
| latest: u64 | ||
| } | ||
|
|
||
| #[inline(always)] |
| fn get_execution_window(self: @ContractState, id: felt252) -> (u64, u64) { | ||
| let start_time = self.execution_started.read(id); | ||
| fn get_execution_window(self: @ContractState, id: felt252) -> ExecutionWindow { | ||
| let start_time = self.execution_state.read(id).started; | ||
|
|
||
| // this is how we prevent the 0 timestamp from being considered valid | ||
| assert(start_time != 0, 'DOES_NOT_EXIST'); |
There was a problem hiding this comment.
hmmm maybe we could just check that canceled is nonzero as well and remove the other logic changes. sorry, i realize this is out of scope for the initial pr.
moodysalem
reviewed
Jan 12, 2024
| let (earliest, latest) = self.get_execution_window(id); | ||
| assert(execution_state.executed.is_zero(), 'ALREADY_EXECUTED'); | ||
|
|
||
| let execution_window = self.get_execution_window(id); |
There was a problem hiding this comment.
this causes a second read of the same slot
not super costly, but wasteful
better to revert if already executed or canceled from this function, since there is no execution window
moodysalem
approved these changes
Jan 12, 2024
|
if you resolve conflicts we can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19
Hey @moodysalem, Sorry for the delay, tell me if that corresponds to what you expect, if so I will complete this PR with all the files with the same method